Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multibin dummy stub regression #753

Closed
rvolosatovs opened this issue Dec 3, 2024 · 2 comments · Fixed by #755
Closed

Multibin dummy stub regression #753

rvolosatovs opened this issue Dec 3, 2024 · 2 comments · Fixed by #755
Labels
bug Something isn't working

Comments

@rvolosatovs
Copy link
Contributor

rvolosatovs commented Dec 3, 2024

Describe the bug

An upgrade from da87d1a to 76d64e7 introduced a regression for a crate with multiple binaries with following structure:

.
├── Cargo.lock
├── Cargo.toml
├── flake.nix
└── src
    └── bin
        ├── bye
        │   └── main.rs
        └── hello.rs

This is likely caused by #752

Reproduction

here's an example crate that breaks:
https://github.com/rvolosatovs/nixify/tree/379112688c027532fd956444b284ade07e83aea8/examples/rust-hello-multibin

refs rvolosatovs/nixify#314

@rvolosatovs rvolosatovs added the bug Something isn't working label Dec 3, 2024
@rvolosatovs
Copy link
Contributor Author

If it helps, here's logic I use to figure out all binaries that would be built by cargo: https://github.com/rvolosatovs/nixify/blob/379112688c027532fd956444b284ade07e83aea8/lib/rust/crateBins.nix#L1-L150

@ipetkov
Copy link
Owner

ipetkov commented Dec 4, 2024

Thank you for the report and the reproduction @rvolosatovs ! The issue was due to not deduping between discovered and declared bin targets, should be fixed with #755!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants