Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: buildDepsOnly crashes on having a build.rs in the config #761

Closed
vikanezrimaya opened this issue Dec 13, 2024 · 1 comment · Fixed by #762
Closed

Regression: buildDepsOnly crashes on having a build.rs in the config #761

vikanezrimaya opened this issue Dec 13, 2024 · 1 comment · Fixed by #762
Labels
bug Something isn't working

Comments

@vikanezrimaya
Copy link

Describe the bug
Presence of a build.rs without specifying crate name and version causes an eval failure due to rewritten Cargo.toml referring to a path in /nix/store, which is forbidden. This is a regression introduced in 9ed3180 (#750), found by bisection.

Reproduction
https://github.com/vikanezrimaya/crane-build.rs-bug-repro
@vikanezrimaya vikanezrimaya added the bug Something isn't working label Dec 13, 2024
@ipetkov ipetkov mentioned this issue Dec 16, 2024
Merged
4 tasks
@ipetkov
Copy link
Owner

ipetkov commented Dec 16, 2024

Thanks for the report and reproduction @vikanezrimaya ! Should be fixed with #762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cargoTomlContents: ignore context of Cargo.toml file ipetkov/crane
2 participants
@ipetkov @vikanezrimaya