Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamically import codecs and hashers and remove from bundle #452

Open
4 tasks
SgtPooki opened this issue Oct 18, 2024 · 0 comments
Open
4 tasks

feat: dynamically import codecs and hashers and remove from bundle #452

SgtPooki opened this issue Oct 18, 2024 · 0 comments
Labels
effort/days Estimated to take multiple days, but less than a week exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/architecture Core architecture of project kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now status/ready Ready to be worked

Comments

@SgtPooki
Copy link
Member

Is your feature request related to a problem? Please describe.

When bundling this package, we want to make it possible for consumers to customize codecs and hashers. #415 made it possible to customize the links; now, we should allow consumers bundling this package to decide whether they want to import all the hashers & codecs or only some.

Describe the solution you'd like

Describe alternatives you've considered

  • Include all imports not-dynamically: this increases bundle size and requires us to come edit this package any time we want to edit the explorer in explore.ipld.io or ipfs-webui

Additional context

This package is only included in ipfs-webui and explore.ipld.io, but we may wish to add new hashers, or remove others, and it would be nice if we could do that easily.

What is enabled by adding this feature

We will be able to allow further customization without as many edits to this package

This issue isn't tracking the work to customize hashers & codecs, but that should be the next step. Ideally we could pass functions into HeliaProvider or ExploreProvider to load hashers & codecs.

@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Oct 18, 2024
@SgtPooki SgtPooki changed the title feat: mark codecs and bases feat: dynamically import codecs and hashers and remove from bundle Oct 18, 2024
@SgtPooki SgtPooki added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue good first issue Good issue for new contributors exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now kind/architecture Core architecture of project effort/days Estimated to take multiple days, but less than a week status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to take multiple days, but less than a week exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/architecture Core architecture of project kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now status/ready Ready to be worked
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant