Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: grepip's --include-cidrs flag causes the program to ignore CIDRs #222

Open
T145 opened this issue Jul 20, 2024 · 1 comment
Open

Comments

@T145
Copy link

T145 commented Jul 20, 2024

Running the following command on a list of IPs and CIDRs prints only the IPs.

ipinfo grepip -4hox --include-cidrs --nocolor

Intuitively, I'd suggest something like this to produce the same output:

ipinfo grepip -4hox --exclude-cidrs --nocolor
@abdullahdevrel
Copy link
Contributor

Hi @T145,

Sorry for the late reply. Tricky stuff. I can see why this is an issue:

image

The CLI supports the following parameters:

--only-matching, -o
  print only matched IP in result line, excluding surrounding content.
--include-cidrs
  prints the CIDRs too.
--include-ranges
  prints the Ranges too.
--cidrs-only
  prints the CIDRs only.
--ranges-only
  prints the Ranges only.

I will open an internal ticket and see what the engineers think. Thank you.

CC: @max-ipinfo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants