Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max recursion depth for provider workflow info requests #477

Open
bgins opened this issue Dec 13, 2023 · 1 comment
Open

Add max recursion depth for provider workflow info requests #477

bgins opened this issue Dec 13, 2023 · 1 comment
Labels
networking Features, functionality involving networking

Comments

@bgins
Copy link
Contributor

bgins commented Dec 13, 2023

Summary

Problem

Workflow info requests may be made recursively in search of a provider. Recursion is not currently limited.

Impact

Without limits on recursion, we may end up infinite recursion and potentially cycles as providers lose memory of who has already been asked.

Solution

Pass a counter when making recursive requests to set a max recursion depth.

@bgins bgins added the networking Features, functionality involving networking label Dec 13, 2023
@bgins
Copy link
Contributor Author

bgins commented Jan 12, 2024

Another approach to limiting recursion by tracking which supposed providers have been visited. We could derive the count from the list, and it gives us more information to not make repeated requests to supposed providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
networking Features, functionality involving networking
Projects
None yet
Development

No branches or pull requests

1 participant