Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API features #417

Open
B1ackt34 opened this issue Sep 15, 2020 · 7 comments
Open

New API features #417

B1ackt34 opened this issue Sep 15, 2020 · 7 comments

Comments

@B1ackt34
Copy link

Is it possible in future versions to add the following API?

Daily trading volume

Thanks in advance

@uaktags
Copy link
Collaborator

uaktags commented Sep 15, 2020

Add it to what? The exchanges?
If so, we already do for most exchanges that offer it (now whether or not that gets shown is a different question).

@B1ackt34
Copy link
Author

No i mean the daily volume of coins traded in total ... with the data taken from the blockchain.
It is an important value to understand if the currency is used, beyond purchases / sales.

@svenrenhoek
Copy link

I have yet to see an exchange use the actual blockchain in trading activities, except for, maybe, some swap sites. Exchanges sweep deposits into their own wallet and credit/debit trading accounts for the amount deposited or withdrawn. All trading activity is then recorded on the exchange's trading DB. Only deposits and withdrawals to/from the exchange actually hit the blockchain.

@B1ackt34
Copy link
Author

If I send coins to another user, they are not registered on exchanges.
If I pay for online services with coins, neither

@svenrenhoek
Copy link

svenrenhoek commented Sep 16, 2020

Ok. I misinterpreted what you meant by "traded". I don't think this is something that generic explorer should be doing. You would need to identify the addresses that you want to include/exclude from "Daily trading volume", sort and sum up the data. The addresses would be different on every chain. This is something better accomplished using a customized script querying the DB, then displaying the output.

edit - this assumes the includable/excludable addresses transact is a defined way, and do not perform transactions that are both includable and excludable. Then you would have to identify the type of data you are looking for on a per transaction basis. Not really feasible for a generic explorer.

@B1ackt34
Copy link
Author

Thank you for answer ... i'll follow your advices !

@uaktags
Copy link
Collaborator

uaktags commented Sep 16, 2020

To add to that, you're querying every TX that is not a coinbase origin or any other parameter you would wish to exclude. Some have done similar efforts to create line charts in the past to just show movement flow.

Fyi, charting requires storing of results (by day) in order to cache it so you don't dos yourself.

A simple ticker of the last 24hrs can be live that says how much has moved, but I'd still recommend mocking that query to the cron script and having it be delayed to ease the server strain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants