Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear how servers should send cap updates #477

Open
emersion opened this issue Dec 1, 2021 · 2 comments · May be fixed by #480
Open

Unclear how servers should send cap updates #477

emersion opened this issue Dec 1, 2021 · 2 comments · May be fixed by #480

Comments

@emersion
Copy link
Contributor

emersion commented Dec 1, 2021

Is this valid if a server looses the ability to perform SASL EXTERNAL auth?

CAP NEW sasl=PLAIN,EXTERNAL
[…]
CAP NEW sasl=PLAIN

Or should the server send a CAP DEL sasl in-between? The latter would have some annoying consequences, e.g. the client will need to CAP REQ sasl again, even though the server never lost the ability to perform SASL PLAIN auth.

@slingamn
Copy link
Contributor

slingamn commented Dec 1, 2021

I don't know that those consequences are necessarily true, but it seems to me that this is just a new value of the sasl CAP, and the server should be able to push it out to clients using CAP NEW without the need for CAP DEL. The spec does say this (in the context of CAP LS, not cap-notify, but the analogy seems clear):

If a capability with values is sent multiple times, the last one received takes priority.

@emersion
Copy link
Contributor Author

emersion commented Dec 1, 2021

Oh, I missed it, thanks. Yes, I think that makes the most sense as well. I'll send a PR to disambiguate if you don't mind?

emersion added a commit to emersion/ircv3-specifications that referenced this issue Dec 2, 2021
@emersion emersion linked a pull request Dec 2, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants