Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to using ToolHandle everywhere #11

Open
gordonwatts opened this issue Feb 3, 2022 · 0 comments
Open

Convert to using ToolHandle everywhere #11

gordonwatts opened this issue Feb 3, 2022 · 0 comments

Comments

@gordonwatts
Copy link
Member

From Nils:

As for using a regular ToolHandle, create it with an auto-declaring inline constructor, e.g. change:
asg::AnaToolHandleTrig::TrigDecisionTool m_trigDec;
to:
ToolHandleTrig::TrigDecisionTool m_trigDec {this, "trigDec", "Trig::TrigDecisionTool/TrigDecisionTool"};

And then move the configuration to python, e.g. something like:
addPrivateTool (alg, "trigDec", "Trig::TrigDecisionTool")
addPrivateTool (alg, "trigDec.ConfigTool", "TrigConf::xAODConfigTool")
alg.trigDec.TrigDecisionKey = "xTrigDecision"

and then you don't need anything in the constructor and in initialize() you just need:
ANA_CHECK (m_trigDec.retrieve());

There also seems to be a Trigger CP sequence defined, but I never used it: https://gitlab.cern.ch/atlas/athena/-/blob/21.2/PhysicsAnalysis/Algorithms/TriggerAnalysisAlgorithms/python/TriggerAnalysisSequence.py

Please note that the trigger people are always very insistent that we can't just prepare some trigger sequence that will work for everyone, but that we will need a number of sequences for different cases and then there will still be a sizable number of users who need something custom just for their analysis. I don't know if that is an accurate assessment or if they are just really proud of how complicated the trigger is.

Cheers,
Nils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant