Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlap removal depends on a PV being present - find a way to filter out events like that #18

Open
gordonwatts opened this issue Mar 18, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@gordonwatts
Copy link
Member

Currently, you'll get a hard crash due to overlap removal if an event doesn't have a PV:

TauEfficiencyCorrectio...WARNING Found tau with unknown decay mode. Skip efficiency correction.
Package.EventLoop        INFO    Processed 30000 events
OverlapRemovalAlg.over...FATAL   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/AnalysisCommon/AssociationUtils/Root/MuJetOverlapTool.cxx:219 (const Vertex* ORUtils::MuJetOverlapTool::getPrimVtx() const): No primary vertex in the PrimaryVertices container!
OverlapRemovalAlg.over...ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/AnalysisCommon/AssociationUtils/Root/MuJetOverlapTool.cxx:155 (virtual StatusCode ORUtils::MuJetOverlapTool::findOverlaps(const MuonContainer&, const JetContainer&) const): Failed to call "vtx != nullptr"
OverlapRemovalAlg.over...ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/AnalysisCommon/AssociationUtils/Root/MuJetOverlapTool.cxx:134 (virtual StatusCode ORUtils::MuJetOverlapTool::findOverlaps(const IParticleContainer&, const IParticleContainer&) const): Failed to call "findOverlaps(static_cast<const xAOD::MuonContainer&>(cont1), static_cast<const xAOD::JetContainer&>(cont2))"
OverlapRemovalAlg.over...ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/AnalysisCommon/AssociationUtils/Root/OverlapRemovalTool.cxx:147 (StatusCode ORUtils::OverlapRemovalTool::removeOverlap(const ToolHandle<ORUtils::IOverlapTool>&, const IParticleContainer*, const IParticleContainer*) const): Failed to call "tool->findOverlaps(*cont1, *cont2)"
OverlapRemovalAlg.over...ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/AnalysisCommon/AssociationUtils/Root/OverlapRemovalTool.cxx:124 (virtual StatusCode ORUtils::OverlapRemovalTool::removeOverlaps(const ElectronContainer*, const MuonContainer*, const JetContainer*, const TauJetContainer*, const PhotonContainer*, const JetContainer*) const): Failed to call "removeOverlap(m_muJetORT, muons, jets)"
OverlapRemovalAlg        ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms/Root/OverlapRemovalAlg.cxx:112 (virtual StatusCode CP::OverlapRemovalAlg::execute()): Failed to call "m_overlapTool->removeOverlaps (electrons, muons, jets, taus, photons, fatJets)"
Package.EventLoopComp_...ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/D3PDTools/AnaAlgorithm/Root/AnaAlgorithmWrapper.cxx:88 (virtual StatusCode EL::AnaAlgorithmWrapper::execute()): failed to call execute() on algorithm: OverlapRemovalAlg
Package.EventLoop        ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/D3PDTools/EventLoop/Root/Worker.cxx:647 (StatusCode EL::Worker::algsExecute()): while calling execute() on algorithm OverlapRemovalAlg
Package.EventLoop        ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/D3PDTools/EventLoop/Root/Worker.cxx:523 (StatusCode EL::Worker::processEvents(EL::EventRange&)): processing event 30236 on file DAOD_PHYS.23294912._000033.pool.root.1
Package.EventLoop        ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/D3PDTools/EventLoop/Root/Worker.cxx:769 (StatusCode EL::Worker::directExecute(const SH::SamplePtr&, const EL::Job&, const string&, const SH::MetaObject&)): Failed to call "processEvents (eventRange)"
Package.EventLoop        ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/D3PDTools/EventLoop/Root/DirectDriver.cxx:81 (virtual StatusCode EL::DirectDriver::doManagerStep(EL::Detail::ManagerData&) const): Failed to call "worker.directExecute (*sample, *data.job, data.submitDir, data.options)"
Package.EventLoop        ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/D3PDTools/EventLoop/Root/ManagerData.cxx:67 (StatusCode EL::Detail::ManagerData::run()): while performing manager step 14
Package.EventLoop        ERROR   /build/atnight/localbuilds/nightlies/AnalysisBase/21.2/athena/PhysicsAnalysis/D3PDTools/EventLoop/Root/ManagerData.cxx:68 (StatusCode EL::Detail::ManagerData::run()): on submission directory /home/atlas/rel/build/bogus
WARNING servicex-release-testing-3 atlas_xaod_cpp_transformer ba7d951e-1262-4fde-a065-17b148facba2 Retry 2 of 3 for root:::xrootd-atlas.cr.cnaf.infn.it:1094::atlas:atlasdatadisk:rucio:mc16_13TeV:63:f8:DAOD_PHYS.23294912._000033.pool.root.1: Failed to transform input file root://xrootd-atlas.cr.cnaf.infn.it:1094//atlas/atlasdatadisk/rucio/mc16_13TeV/63/f8/DAOD_PHYS.23294912._000033.pool.root.1: Output file /home/atlas/root:::xrootd-atlas.cr.cnaf.infn.it:1094::atlas:atlasdatadisk:rucio:mc16_13TeV:63:f8:DAOD_PHYS.23294912._000033.pool.root.1 was not found -- errors: Configured GCC from: /opt/lcg/gcc/8.3.0-cebb0/x86_64-centos7/bin/gcc
Configured AnalysisBase from: /usr/AnalysisBase/21.2.197/InstallArea/x86_64-centos7-gcc8-opt

We need a way to filter out those events before OR is run, if it is to be run.

This was running a simple fully calibrated query on the dataset rucio://mc16_13TeV:mc16_13TeV.361022.Pythia8EvtGen_A14NNPDF23LO_jetjet_JZ2W.deriv.DAOD_EXOT15.e3668_s3126_r9364_r9315_p4696.

As a result, we are turning off overlap removal for these notebooks for now - until we know how to filter for them.

@gordonwatts gordonwatts added the bug Something isn't working label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant