Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-restricted flag is poorly named #339

Open
gjermundgaraba opened this issue Mar 5, 2023 · 0 comments
Open

update-restricted flag is poorly named #339

gjermundgaraba opened this issue Mar 5, 2023 · 0 comments

Comments

@gjermundgaraba
Copy link

I was unsure what exactly the update-restricted flag meant (side-note: the cli descriptions of the mint-restricted and update-restricted flags are not helpful), so I went into the code to find out.

While mint-restricted sort of makes sense; it restricts how can mint to the creator. I sort of guessed this was what it meant.

But update-restricted was very unclear. It was not clear that it actually mean nobody can update their NFTs. Following the logic of the "mint-restricted" I would perhaps guess the creator could do it.

My suggestion: change the name of that flag to something like "disallow-updating-nfts", or perhaps consider having it the other way around (and false by default): "allow-update-nfts".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant