Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker database migration should be automatic (default setting) #3526

Open
tjb-altf4 opened this issue Feb 23, 2023 · 1 comment
Open

Docker database migration should be automatic (default setting) #3526

tjb-altf4 opened this issue Feb 23, 2023 · 1 comment
Labels
feature request New functionality added to Iron Fish

Comments

@tjb-altf4
Copy link

What happened?

I noticed that database migrations are not automatic in docker. For those of us who automate our docker upgrades, or perhaps don't pay attention after pulling new image, this causes the container to silently fail (the node drops out) and the container will stop if a database migration is required.

I've seen the related issue #3145, and I'd suggest instead that --upgrade should be the default arg.
Instead, for the (few?) use cases where migrations are not wanted, the use of static tags to stay on previous builds, or manually overriding of the docker CMD should be preferred.

In my own case, I have now added start --upgrade to the container startup args to cover this scenario, so at a minimum this should be added to documentation as a recommended start-up command for the average user.

Version

0.1.68

Debug output

No response

Relevant log output

No response

Graffiti

tjb_altf4

@tjb-altf4 tjb-altf4 added the bug Something isn't working label Feb 23, 2023
@hughy hughy added feature request New functionality added to Iron Fish and removed bug Something isn't working labels Feb 27, 2023
@hughy
Copy link
Contributor

hughy commented Apr 19, 2023

There is also a config variable, databaseMigrate, that you can set to true to set your node to automatically apply migrations on start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New functionality added to Iron Fish
Projects
None yet
Development

No branches or pull requests

2 participants