Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The homepage is outdated #14

Open
aochagavia opened this issue Sep 21, 2014 · 13 comments
Open

The homepage is outdated #14

aochagavia opened this issue Sep 21, 2014 · 13 comments

Comments

@aochagavia
Copy link

No description provided.

@zzmp
Copy link
Member

zzmp commented Sep 22, 2014

Can you go into any more detail on what is outdated? Travis recommits every module when a change is merged - if a module is broken, it will be outdated. Is that what you're seeing?

@reem
Copy link
Member

reem commented Sep 22, 2014

No the actual homepage information is embarrassingly out of date.

@zzmp, maybe we can make the homepage mirror the iron/iron README somehow?

@zzmp
Copy link
Member

zzmp commented Sep 23, 2014

This'll be good to roll in with session rewrites - it'll force me to grasp it better.

@reem
Copy link
Member

reem commented Sep 23, 2014

Ok. @zzmp Feel free to make a PR with changes.

@hannobraun
Copy link
Contributor

The site at http://ironframework.io/ is not up to date with the contents of this repository. See the "Hello, world" example: On the website, hello_world returns IronResult, but the index.html in this repository correctly returns IronResult<Response>.

@reem
Copy link
Member

reem commented Oct 13, 2014

@hannobraun That is (embarassingly) because <Response> is not escaped, so is treated like an HTML tag and not rendered, it is fetching the content from this repository.

@hannobraun
Copy link
Contributor

Ah, got it. Let me see what I can do about that :)

@hannobraun
Copy link
Contributor

See #16

@ProtectedMode
Copy link
Contributor

The example still seems outdated, since Response::with is removed / deprecated / moved / something else, at least it doesn't seem to compile.

@reem
Copy link
Member

reem commented Nov 22, 2014

Response::with has now actually been removed after being deprecated for a bit. I will update the homepage again to reflect this.

@reem
Copy link
Member

reem commented Nov 22, 2014

Updated. It now is a bit too new but that should be fixed as soon as an open PR to iron is fixed.

@rossettistone
Copy link

This might just be because the example is still ahead of the main codeline, but I'm finding the "hello world" remains broken there because of 1) a reference to Status, which doesn't exist and 2) a missing #![feature(globs)].

No worries if this is about to be fixed - just wanted to give a heads up that I ran into it. Ultimately found hello.rs from the main repo examples, which worked fine.

@reem
Copy link
Member

reem commented Dec 29, 2014

Ya, this page is chronically outdated because I don't know when it breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants