Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in EstimatePointWiseNormalsWithFastEigen3x3 #6967

Closed
kogn opened this issue Sep 14, 2024 · 0 comments · Fixed by #6980
Closed

Error in EstimatePointWiseNormalsWithFastEigen3x3 #6967

kogn opened this issue Sep 14, 2024 · 0 comments · Fixed by #6980

Comments

@kogn
Copy link

kogn commented Sep 14, 2024

https://github.com/isl-org/Open3D/blob/main/cpp/open3d/t/geometry/kernel/PointCloudImpl.h#L959

        else if (covariance_ptr[0] < covariance_ptr[4] &&
                   covariance_ptr[0] < covariance_ptr[8]) {
            normals_ptr[0] = 0.0;
            normals_ptr[1] = 1.0;
            normals_ptr[2] = 0.0;
            return;
        }

should be

        else if (covariance_ptr[4] < covariance_ptr[0] &&
                   covariance_ptr[4] < covariance_ptr[8]) {
            normals_ptr[0] = 0.0;
            normals_ptr[1] = 1.0;
            normals_ptr[2] = 0.0;
            return;
        }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant