Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile tables are not responsive and force horizontal scrolling #67

Open
akrawchyk opened this issue May 30, 2017 · 5 comments
Open

Mobile tables are not responsive and force horizontal scrolling #67

akrawchyk opened this issue May 30, 2017 · 5 comments
Labels

Comments

@akrawchyk
Copy link
Contributor

Consider adding responsive styles or something like https://github.com/filamentgroup/tablesaw to avoid the screenshot below:

screenshot_20170530-092440

@akrawchyk akrawchyk added the Bug label May 30, 2017
@akrawchyk
Copy link
Contributor Author

akrawchyk commented May 30, 2017

There's a catch to this...

First, the way we "bundle" JavaScript could be improved to make it easier to add new plugins. Seems like we're copying vendor files then concatenating them. This works but could be improved especially since we are committing the vendor files in 2 different places.

Second, while we can use Github Flavored Markdown to render tables, we also use hexo's highlighting utility to provide syntax highlighting in the HTML output. Unfortunately, this utility wraps code in a table so we would either need to avoid using tablesaw on code tables or change the output of the highlighter to not use tables.

@josephabrahams
Copy link
Member

Having the vendor files in 2 places is an error. Looks like it should be removed. My-b.

@akrawchyk
Copy link
Contributor Author

@josephabrahams no big deal just taking notes for myself to fix later. Would be nice to avoid committing them at all though!

@josephabrahams
Copy link
Member

There's a reason the js is handled the way it is (not to say it can't be changed). If I recall it has to do with built in Hexo asset handling.

@josephabrahams
Copy link
Member

Actually, I don't think that stuff is supposed to be committed at all.

See: https://github.com/istrategylabs/sudo/blob/master/gulpfile.js#L13
And: https://github.com/istrategylabs/sudo/blob/master/.gitignore#L7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants