Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for problem matcher logic #67

Open
jamescurtin opened this issue Dec 7, 2022 · 2 comments
Open

Add test cases for problem matcher logic #67

jamescurtin opened this issue Dec 7, 2022 · 2 comments
Assignees

Comments

@jamescurtin
Copy link
Member

    > This looks great!

Thanks.

Do you think it would be possible to add a job to the test workflow that asserts the regex in isort-matcher.json matches against an expected file?

Could we compromise on merging this as is and creating an issue in the project assigned to me, then I'll try and do a more general helper action to test problem matchers, as the point you raise is valid for the others I use elsewhere too?

If isort's error message ever changed, this should be sufficient to let us know an additional pattern would need to be added.

If it was ever going to be changed, it would be beneficial to encourage them to add a separator between the filename and the error message, especially if they started to add additional error messages in future...

Originally posted by @peternewman in #66 (comment)

@jamescurtin
Copy link
Member Author

FYI @peternewman; Doesn't seem like I can assign you.

@peternewman
Copy link
Contributor

FYI @peternewman; Doesn't seem like I can assign you.

That was my plan all along! Mwahahaha!

More seriously, I think you just need to make people members of the org with read access to the repo to be able to assign them, that works for me on another org. I have a secret team called foo-contributors and add people to that.

Although maybe having replied to this issue will be sufficient now? Again it seems like it from past experience, unless it's the issue reporter that's the required state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants