Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No verbosity at all for succesful checks #72

Open
niemiaszek opened this issue Dec 19, 2022 · 4 comments
Open

No verbosity at all for succesful checks #72

niemiaszek opened this issue Dec 19, 2022 · 4 comments

Comments

@niemiaszek
Copy link

I tried to setup linting workflow using this action and it obviously works as intended, but it lacks any verbosity, even with --verbose option.

I'd expect successful workflow to output something similar to black formatter action, but there is none. Such example can be seen in this succesful check of mine. Verbosity for failed check exists, but I'd say it's also unsatisfying. Example in this failed check of mine.

Output of checks drastically differs from the one directly ran from isort cli.

@mf-maymay
Copy link

Came here to report this same issue, but with emphasis on the output for failed checks.

The command line output is informative, showing exactly which imports are problematic.
However, the output from this action only shows which files have poorly-sorted imports.

@elliot-100
Copy link

elliot-100 commented May 22, 2024

Agree. The docs say that the default option is equivalent to `isort . --check-only --diff' but I don't find that to be the case.

@niemiaszek your links don't work for me. Maybe add extract of output here?

I think I will add a new issue for my specific case, as it's not necessarily the same as yours.

[Edit: done: #90 ]

@niemiaszek
Copy link
Author

niemiaszek commented May 22, 2024

@niemiaszek your links don't work for me. Maybe add extract of output here?

You're right, these links stopped working, as Github Actions runs have expiration date. Sorry for that, but it's been 1.5 year and I hoped to resolve this issue a bit faster. This Action seems abandoned.

I stopped using this action so I won't be able to help. Last time I used isort in actions was with CLI. Currently I fully use Ruff for formatting and linting, with import sorting option (replacement for black and isort, with small differences).

Looks like they're getting official Action support soon, where now you could use CLI with great success.

@elliot-100
Copy link

Thanks @niemiaszek, no problem. I have moved to ruff format instead of isort + black for my own projects, but found/remembered this issue while troubleshooting an existing project. Will try isort CLI for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants