Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link-stamp binaries with vendor specific info #33421

Closed
mandarjog opened this issue Jun 14, 2021 · 2 comments · May be fixed by istio/pkg#368
Closed

link-stamp binaries with vendor specific info #33421

mandarjog opened this issue Jun 14, 2021 · 2 comments · May be fixed by istio/pkg#368
Assignees
@shamsher31
Labels
area/test and release area/user experience lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while

Comments

@mandarjog
Copy link
Contributor

At present version.BuildInfo contains general istio info.

./out/linux_amd64/pilot-discovery version -o json

{
  "clientVersion": {
    "version": "1.11.6",
    "revision": "14db30df83cabb738ae9beb57d7219b3f273c3af-dirty",
    "golang_version": "go1.16.4",
    "status": "Clean",
    "tag": "1.7.0-alpha.0-3013-g14db30df83"
  }
}

We should add a vendor_version string for build info. This information is typically available in the docker build image, but that does not work for VMs.
For example at Google, the image names are pilot:1.9.5-asm.4 so 1.9.5-asm.4 is vendor version.
@mandarjog
Copy link
Contributor Author

Alternatively vendors can just change the version link stamp to include 1.9.5-asm.4

@shamsher31 shamsher31 self-assigned this Jun 15, 2021
@shamsher31 shamsher31 mentioned this issue Jun 15, 2021
Draft
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Sep 13, 2021
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-06-14. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shamsher31 shamsher31

Labels
area/test and release area/user experience lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add vendor_version for build info shamsher31/pkg
4 participants
@mandarjog @shamsher31 @esnible @istio-policy-bot