Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on istioctl install when the version is EOL #41747

Closed
howardjohn opened this issue Nov 2, 2022 · 2 comments · Fixed by #42256 · May be fixed by istio/release-builder#1294
Closed

Warn on istioctl install when the version is EOL #41747

howardjohn opened this issue Nov 2, 2022 · 2 comments · Fixed by #42256 · May be fixed by istio/release-builder#1294
Assignees
@zufardhiyaulhaq
Labels
area/user experience lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while

Comments

@howardjohn
Copy link
Member

Strawman implementation:

  • Before we ship a release, guess when we will EOL it (this is generally known, but in theory we can change the EOL so its not perfect)
  • In istioctl. add if today > EOL date { warn }
  • In helm, NOTES.txt can do the same thing

The reason we guess the EOL is because we don't want to do a dynamic internet lookup. Because we might be wrong, we may want to say something like "Warning: may be installing an EOL version: see istio.io/support for supported releases" or something, rather than "You are installing a EOL version"

cc @therealmitchconnors
@zufardhiyaulhaq
Copy link
Member

Hi @howardjohn can you assign this to me?

This was referenced Dec 3, 2022
Merged
Open
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Mar 3, 2023
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-12-03. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zufardhiyaulhaq zufardhiyaulhaq

Labels
area/user experience lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while
Projects
None yet
Milestone
No milestone
3 participants
@howardjohn @zufardhiyaulhaq @istio-policy-bot