Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Checkout and order tax issue with tax and without tax #18

Open
syabdullah opened this issue Jun 29, 2019 · 1 comment
Open

Fix Checkout and order tax issue with tax and without tax #18

syabdullah opened this issue Jun 29, 2019 · 1 comment

Comments

@syabdullah
Copy link

Hello

If you get the wrong price at order page base price - tax price go to "1- Fix Order price".
if you have an issue in checkout to show cod price with tax go to "2- Show price with a tax or without tax in the checkout page "


1- Fix Order price

please go to
msp/cashondelivery/Block/Sales/Cashondelivery.php

change line 48 ` - to +
From
'value' => $source->getBaseMspCodAmount() - $source->getBaseMspCodTaxAmount(),
To
'value' => $source->getBaseMspCodAmount() + $source->getBaseMspCodTaxAmount(),

this it will fix the price on order page and mail.


To Get Base price with tax Tax in customer order page
'value' => $source->getBaseMspCodAmount() + $source->getBaseMspCodTaxAmount(),

To Get Base price without tax in customer order page
'value' => $source->getBaseMspCodAmount() ,
`***********************************************************

2- Show price with a tax or without tax in the checkout page

go to
msp/cashondelivery/Model/Total/Quote/Cashondelivery.php

Change in line 100 from
From : without tax
'value' => $total->getBaseMspCodAmount() ,
To: with tax
'value' => $total->getBaseMspCodAmount() + $total->getBaseMspCodTaxAmount(),


Abdullah Almohammad

@ITA003
Copy link

ITA003 commented Sep 9, 2021

Could be useful if can release this fix with with an option in Backend where choose if show the price with or without tax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants