Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor will import publiccodes by their remote url #125

Merged
merged 4 commits into from
Jun 8, 2020
Merged

Conversation

sebbalex
Copy link
Member

@sebbalex sebbalex commented Feb 8, 2020

As for #95 Editor should be capable to import publiccodes by their remote url. We will use the external validator to tackle cors exceptions due to differents code hosting platform and domains (some could be on premises with custom CORS rules).

@sebbalex sebbalex added the enhancement New feature or request label Feb 8, 2020
@sebbalex sebbalex added this to the 1.4.0 milestone Feb 8, 2020
@sebbalex sebbalex requested a review from libremente February 8, 2020 17:57
@libremente
Copy link
Member

@sebbalex what should we do with this? Are we able to merge it? If so, we should probably review the releases.

@sebbalex sebbalex requested review from libremente and removed request for libremente April 2, 2020 10:20
@sebbalex
Copy link
Member Author

@sebbalex what should we do with this? Are we able to merge it? If so, we should probably review the releases.

I faced in a strange behaviour about this feature. I'm having a closer look right now.

@sebbalex sebbalex modified the milestones: 1.6.0, 1.5.0 May 28, 2020
@sebbalex sebbalex requested a review from libremente June 5, 2020 14:10
@sebbalex sebbalex merged commit 176884d into master Jun 8, 2020
@sebbalex sebbalex deleted the url-param branch June 8, 2020 14:29
@sebbalex sebbalex linked an issue Jun 8, 2020 that may be closed by this pull request
@sebbalex sebbalex restored the url-param branch September 22, 2020 10:36
@sebbalex sebbalex deleted the url-param branch September 22, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow URL parameters
2 participants