Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error string handling for OpenSSL-3.0.0 needs further fixing #110

Open
msalle opened this issue Jan 13, 2023 · 2 comments
Open

error string handling for OpenSSL-3.0.0 needs further fixing #110

msalle opened this issue Jan 13, 2023 · 2 comments
Assignees

Comments

@msalle
Copy link

msalle commented Jan 13, 2023

My comment from original "OpenSSL-3.0.0-beta1 fixes" merge request:

I just realised that for a proper fix for OpenSSL3.0 all occurrences of ERR_PACK need to be checked, since the function part is deprecated and set to 0 in ERR_PACK. That can result in overwriting other entries (library name or reasons).
This concerns:

  • src/ac/error.c: should be skipped entirely
  • src/sslutils/scutils.c: should skip loading the scerr_str_functs
  • src/sslutils/sslutils.c: should skip loading the prxyerr_str_functs
    Also references to ERR_func_error_string also need adapting since that will always be (null). That concerns src/socklib/Server.cpp and src/common/data.cc
    All these are not really breaking voms, but can lead to misleading and/or faulty error messages.
    See also Remove func name from errors, etc. openssl/openssl#9058

Originally posted by @msalle in #98 (comment)

@giacomini
Copy link
Member

giacomini commented Jun 14, 2024

@msalle would you please have a look at the changes in #133? it's quite minimal and doesn't cover all what is needed for properly handling errors according to OpenSSL 3, but at least it should allow to have correctly formatted error messages. Thanks.

@giacomini
Copy link
Member

I have merged the PR with the existing changes. I'll address the rest of this issue subsequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants