Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levels and Scores not properly calculated, when completing Skill #111

Closed
Amar-Bolkan opened this issue Jun 9, 2022 · 1 comment
Closed
Labels
bug Something isn't working frontend
Milestone

Comments

@Amar-Bolkan
Copy link
Contributor

Amar-Bolkan commented Jun 9, 2022

Completing a Skill doesnt update the current Score and Level correctly.

image

image

image

Findings:

  • selecting Team 3 and completing the skill Input Validation increases the Score by one. However reopening the skill doesn't decrease the Score counter. Setting the skill to Achieved again doesn't increase the counter again.
  • When changing the skill status the ngOnChanges method in src/main/webapp/app/custom/teams/teams-status/teams-status.component.ts is triggered. However the changes to the AchievableSkill arent contained in the SimpleChanges object.
  • Explicitly setting the Skill status in src/main/webapp/app/custom/teams/skills/teams-skills.component.ts Line 224 and Line 235 , before updating the AchievableSkill doesn't effect the content of the SimpleChanges object.
@Amar-Bolkan Amar-Bolkan added bug Something isn't working help wanted Extra attention is needed frontend backend and removed backend labels Jun 9, 2022
@Weltraumschaf
Copy link
Member

Possibly caused by #85

@rseedorff rseedorff added this to the v2.0 milestone Jun 15, 2022
@Weltraumschaf Weltraumschaf removed the help wanted Extra attention is needed label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

3 participants