Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common functionalities of the auditors of an entity into abstract parent class #42

Open
twwd opened this issue Oct 2, 2024 · 0 comments
Labels
maintainability Required refactorings, code smells etc.

Comments

@twwd
Copy link
Collaborator

twwd commented Oct 2, 2024

In the most (all?) auditors, we start the audit with looping over all entities, check whether they are ignored and then perform the actual check. We can extract the common parts into a abstract base class per entity (e..g., client, idp) like it's done for realm auditors with #41.
We might even find a common abstract base class for all entity types using generics but that probably leads to over-engineering.

@twwd twwd added the maintainability Required refactorings, code smells etc. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainability Required refactorings, code smells etc.
Projects
None yet
Development

No branches or pull requests

1 participant