Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for Libraries that aren't in the workspace #4

Open
mettke opened this issue May 20, 2020 · 0 comments
Open

Adding Support for Libraries that aren't in the workspace #4

mettke opened this issue May 20, 2020 · 0 comments
Labels
enhancement New feature or request undecided Its unclear how or whether to fix this issue

Comments

@mettke
Copy link
Member

mettke commented May 20, 2020

Currently replacing is only possible on the application as the package metadata is not read for libraries but only the current project. Thus releasing a library which is based on patching would render it impossible to use for other people.

The alternative is to recursively go through all dependencies and check whether one of them has metadata set. If so one would be able to patch that dependency locally and use the replace on the current project to allow building, pretty much as it is done right now.

The disadvantage of this approach is that we might see libraries which will require the use of this tool making it more difficult for newcomers to use libraries.

@mettke mettke added enhancement New feature or request question Further information is requested undecided Its unclear how or whether to fix this issue and removed question Further information is requested labels May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request undecided Its unclear how or whether to fix this issue
Development

No branches or pull requests

1 participant