New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding a route #463

Open

sluggogle opened this issue Aug 11, 2023 · 0 comments

sluggogle commented Aug 11, 2023

These lines make it impossible to override an endpoint and call the parent by super() because parameters will be in iargs and not kwargs

sync-addons/openapi/controllers/pinguin.py

Lines 353 to 355 in 0593839

    
           namespace = get_namespace_by_name_from_users_namespaces( 
        
               authenticated_user, ikwargs["namespace"], raise_exception=True 
        
           )

Also, when overriding we only want to log data for the overriding method and not the parent so we can skip defining data_for_log when kwargs is empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment