Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sparks based scheduler #109

Open
rrnewton opened this issue Jun 22, 2015 · 6 comments
Open

Implement sparks based scheduler #109

rrnewton opened this issue Jun 22, 2015 · 6 comments

Comments

@rrnewton
Copy link
Member

  • Separate package from LVish with minimal depends
  • Will only be an instance of ParFuture/ParMonad, not ParIVar
  • Can be modeled on the monad-par version of same

This should be able to exercise some generic set of Par tests which can apply to both LVish and this new implementation.

@osa1
Copy link
Member

osa1 commented Jul 8, 2015

We'll need some newtypes for this. Where should I define those?

  • par-classes: Seems like a bad place because we may want to keep this small and simple. This change will introduce a monad-par dependency and an implementation. (currently we only define interfaces in this package, it doesn't have any implementations)
  • par-transformers: Seems unrelated.
  • par-collections: Seems unrelated.
  • lvish: May be a good place since current scheduler is also defined there, but we don't need any lvish functionality and we may want to import other schedulers without importing the whole lvish?
  • new package: Seems like the best option for me. We can call it par-schedulers.

@osa1
Copy link
Member

osa1 commented Aug 25, 2015

As previously discussed, we need some refactoring in ParIVar, ParFuture etc. class hierarchy, but the branch for that is causing a lot of trouble now(par-classes-refactor).

So I started gradually merging that branch and I'm hoping to find the patch that's causing breakages on the way.

@rrnewton
Copy link
Member Author

Could you link to a failing CI test log for the trouble? Failing sort tests right?

@osa1
Copy link
Member

osa1 commented Aug 25, 2015

I'm afraid we don't have any CI logs for that, because CI was failing with build problems. I was running tests on my laptop, and approximately 1 out of 10 runs was succeeding, others were failing with "array not sorted" errors and they were sometimes getting stuck.

I tried to implement a MVar-based ParFuture implementation for LVish scheduler(c88abdf), and when I used that in par-mergesort it started to fail with "Blocked indefinitely on MVar operation" errors.

@rrnewton
Copy link
Member Author

Ok, I'll try to code review (c88abdf) soonish.

@rrnewton
Copy link
Member Author

Put the feedback in-line in the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants