-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sparks based scheduler #109
Comments
We'll need some newtypes for this. Where should I define those?
|
As previously discussed, we need some refactoring in ParIVar, ParFuture etc. class hierarchy, but the branch for that is causing a lot of trouble now(par-classes-refactor). So I started gradually merging that branch and I'm hoping to find the patch that's causing breakages on the way. |
Could you link to a failing CI test log for the trouble? Failing sort tests right? |
I'm afraid we don't have any CI logs for that, because CI was failing with build problems. I was running tests on my laptop, and approximately 1 out of 10 runs was succeeding, others were failing with "array not sorted" errors and they were sometimes getting stuck. I tried to implement a MVar-based ParFuture implementation for LVish scheduler(c88abdf), and when I used that in par-mergesort it started to fail with "Blocked indefinitely on MVar operation" errors. |
Ok, I'll try to code review (c88abdf) soonish. |
Put the feedback in-line in the commit. |
ParFuture
/ParMonad
, notParIVar
monad-par
version of sameThis should be able to exercise some generic set of Par tests which can apply to both LVish and this new implementation.
The text was updated successfully, but these errors were encountered: