Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules with same names are confusing to developers #121

Open
osa1 opened this issue Aug 1, 2015 · 1 comment
Open

Modules with same names are confusing to developers #121

osa1 opened this issue Aug 1, 2015 · 1 comment

Comments

@osa1
Copy link
Member

osa1 commented Aug 1, 2015

We should probably rename some of the modules with names like:

  • Internal.Control.LVish.SchedIdempotent
  • Control.LVish.SchedIdempotentInternal

Users won't care since they're not supposed to be used by users, but it's confusing to developers.

@rrnewton
Copy link
Member

rrnewton commented Aug 1, 2015

Yes, that whole notion of putting "Internal" in front caused an ugly hiccup in the git history (caused merge problems after).

Further, the idea was just that it would get internal modules out of the way in the haddocks -- i.e. grouping them together rather than interspersing them. But later I heard (from you?) that there's a simpler way to just hide those internal modules in the haddocks.

Besides Foo.Bar.Internal, with Internal trailing, is the standard idiom, for better or worse....

I can't even remember why there seem to be two modules that are both SchedIdempotent + Internal... that looks horrible.

@rrnewton rrnewton modified the milestone: 2.0 Release May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants