Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Cache VideoJS dependencies for docker to reduce build times #4878

Open
syeopite opened this issue Aug 25, 2024 · 2 comments
Open
Labels
enhancement Improvement of an existing feature

Comments

@syeopite
Copy link
Member

Is your enhancement request related to a problem? Please describe.

The Checking player dependencies part of compiling Invidious takes a huge amount of time on docker builds.

Describe the solution you'd like

The VideoJS dependencies should be cached to mitigate this problem. Although I'm not sure if the lengthy part comes from compiling the VideoJS dependency fetch script itself or from the actual fetching of the dependencies themselves from NPM.

This should be investigated

Describe alternatives you've considered

Additional context

@syeopite syeopite added the enhancement Improvement of an existing feature label Aug 25, 2024
@SamantazFox
Copy link
Member

Yes, I was thinking about making that its own step in the makefile. That would also allow creating release tarballs (requested in #4672)

@syeopite
Copy link
Member Author

Something like this? #4300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants