Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinked BNF #78

Open
mbtaylor opened this issue Mar 24, 2023 · 10 comments
Open

Hyperlinked BNF #78

mbtaylor opened this issue Mar 24, 2023 · 10 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mbtaylor
Copy link
Member

Appendix A of ADQL 2.0 references the external page http://www.ivoa.net/internal/IVOA/IvoaVOQL/adql-bnf-v2.0.html which is a super-useful hyperlinked version of the BNF. It would be great to have a similar thing for ADQL 2.1.

@gmantele
Copy link
Collaborator

I did not even know a such thing existed. Indeed, it could be useful to have that for ADQL-2.1.
Do you know who generated this? And how?

@mbtaylor
Copy link
Member Author

I don't know the answer to either of those questions, but following a bit of googling I'm guessing that whoever it was might have used the tools at https://ronsavage.github.io/SQL/. Some fiddling around is required to make it work, but I think I could get it producing useful output. Since the build is a bit complicated and the output needs some manual intervention I'm not sure if it would be suitable for putting under direct makefile control, but I could have a go at writing a script which at least documents what's done and put it, with the resulting output, in the ADQL repository. Should I do it?

@gmantele gmantele pinned this issue Mar 27, 2023
@gmantele
Copy link
Collaborator

Why not :) You can give it a try. I think it is not really essential, so don't try too hard if it does not work.

@gmantele gmantele added the enhancement New feature or request label Mar 27, 2023
@gmantele gmantele added this to the 2.1 milestone Mar 27, 2023
@mbtaylor
Copy link
Member Author

Implemented I believe in PR #81.

@gmantele
Copy link
Collaborator

gmantele commented Apr 5, 2023

Implemented and merged thanks to #81

@gmantele gmantele closed this as completed Apr 5, 2023
@gmantele gmantele unpinned this issue Apr 5, 2023
@mbtaylor
Copy link
Member Author

I've just realised that this issue didn't get properly resolved. Although the adql-bnf.html file is now in the respository, it is not referenced in the ADQL 2.1 document appendix or otherwise available except by looking in this github repository. Do you think a link could be added to the ADQL 2.1 landing page or that it could otherwise be made available from the IVOA website? It could go in the https://www.ivoa.net/documents/ADQL/20231215/ directory along with the LaTeX source etc. Failing that it could go on the wiki (the ADQL 2.0 version was at https://wiki.ivoa.net/internal/IVOA/IvoaVOQL/adql-bnf-v2.0.html).

@mbtaylor mbtaylor reopened this Feb 22, 2024
@msdemlei
Copy link
Contributor

msdemlei commented Feb 23, 2024 via email

@molinaro-m
Copy link
Member

I suppose an erratum would do, it seems (to me) on the same level of the erratum issued for MOC-2.0, Erratum 1; maybe in the meantime the BNF file can be placed in the ADQL-2.1 folder (documents/ADQL/20231215) on ivoa.net and manually linked to the ADQL-2.1 landing page (we need to define a place there). I know it looks messy, but we still don't have a standard way to attach auxiliary documents to recommendations on the landing pages, maybe this can work as (one) prototyping example.

@mbtaylor
Copy link
Member Author

I would be happy with Marco's suggestion of putting it in documents/ADQL/20231215 and manually linking it on the ADQL-2.1 landing page if that's not too hard to do.

I don't object to issuing an Erratum as well, but I wouldn't say it's necessary, this is more like an Addendum than Erratum.

@gmantele
Copy link
Collaborator

Thank you @mbtaylor for remembering this. It is indeed a good idea to link this document somewhere (in the recommendation or in the landing page)....I should have done it....sorry for that. An Addendum/Erratum seems indeed a good idea too.

If ok with all of you, next week, I can prepare an Erratum for this as well as trying the auxiliaryurl and AUX_FILES features of ivoatex.

In the meantime, manually adding a link on the landing page of ADQL-2.1 may a quick and dirty temporary solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

4 participants