Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

Suggest: Option to turn autocomplete On / Off #157

Open
SkunkerAG opened this issue Dec 14, 2016 · 11 comments
Open

Suggest: Option to turn autocomplete On / Off #157

SkunkerAG opened this issue Dec 14, 2016 · 11 comments
Assignees

Comments

@SkunkerAG
Copy link

Hi,

your plugin is great, but there is a problem when using a lot of tags in one Project(20+).
The autocorrection dropdown list does sometimes not go away on page close or opens to early when starting editing the ticket.

It would be great if a turn on/off option for autocorrection is added.

Thank you

@SkunkerAG
Copy link
Author

SkunkerAG commented Dec 14, 2016

THe problem occurs in Internet Explorer 11 with:

Ubuntu 16.04 (if that dies matter)

Environment:
Redmine version 3.2.1.stable
Ruby version 2.3.1-p112 (2016-04-26) [x86_64-linux-gnu]
Rails version 4.2.7.1
Environment production
Database adapter Mysql2

SCM:
Git 2.7.4
Filesystem

Redmine plugins:
issue_charts 1.3.0
quick_view 0.3.0
redmine_agile 1.4.1
redmine_didyoumean 1.2.0
redmine_editauthor 0.9.0
redmine_issue_badge 0.0.3
redmine_ldap_sync 2.0.8.devel
redmine_lightbox2 0.2.7
redmine_people 1.2.0
redmine_tags 3.1.1
redmine_theme_changer 0.2.0

@marius-balteanu
Copy link
Collaborator

Thanks for reporting the issue. We'll try to reproduce and fix the issue instead of adding an option to disable/enable the autocomplete feature.

@AstraSerg
Copy link
Contributor

I agree with marius. Disable/enable autocomplete feature is not needed. It will be hard to use this plugin without an autocomplition.

@sdwolfz sdwolfz self-assigned this Dec 14, 2016
@sdwolfz
Copy link
Collaborator

sdwolfz commented Dec 14, 2016

I will look into this over the weekend

@marius-balteanu
Copy link
Collaborator

The autocomplete dropdown can be very long on a project with many tags (see below screenshot). I think we can limit the results to 20 (for example).

@PowerKiKi, @SDWolf, let me know what do you think about this change.

screen shot 2016-12-18 at 22 20 04

@PowerKiKi
Copy link
Collaborator

I am not against limiting the result list, but it does not really seem to address the original issue.

Especially I am having a hard time imagining how a page element may "not go away on page close". If the page is actually closed, I really don't see how anything could linger around.

Also I don't think "opens too early" can be a problem. On the contrary I see reactivity and fast feedback as a (great) feature.

IMHO I wouldn't do much until we understand what is the actual root issue. But again, I don't mind all that much to limit the list length.

@ixti
Copy link
Owner

ixti commented Dec 19, 2016

I think limiting to 20 tags is fair enough.

@SkunkerAG
Copy link
Author

SkunkerAG commented Dec 19, 2016

Hi there,

Thanks for your help. Limiting is for me a good idea, but not solving that problem.

Also I don't think "opens too early" can be a problem.

Sadly it can :( It pops up when you're not even editing the ticket, while you're just watching it. Not even hitting F5 (reload) changes this behavior.

"not go away on page close":

I wanted to say with that, if you close editing mode, it does not go away. The list, with 20+ results stays open. Beside that , if you have many results, and the list opens it expands down, and out of the screen. This is why i think limiting is a good idea, too.

But as I said in this post, it's not solving the "showing up in unexpected situations" problem.

plus: we found out, that it's all good in Firefox...

hope to be helpfull :)

@PowerKiKi
Copy link
Collaborator

It seems that there are several different issues, that should probably have been reported separately and with more details. Especially if the "opens too early" is experienced only on a specific browser you should let us know what browsers you tried, and which one did/didn't worked.

@SkunkerAG
Copy link
Author

SkunkerAG commented Dec 19, 2016

Sorry for reporting in one error. That's because I first suggested a 'turn-it-off'-feature.

The browser that has problems with the popup is the one i wrote above: IE 11. Here are more Informations:

Internet Explorer 11
Version 11.0.9600.18524
Updateversion 11.0.37 (KB3197655)

Firefox 50.0.1 Okay
Chrome: Okay
that's all versions I can test here.

this happened e.g. , when I switched the tracker to 'Fehler' (Text means 'error').

image

The focus was not even close to the Tag-Field.

and here is a pic from the View-Mode of a ticket. Edit is not jet pressed ..
image

to be more precise: It happens, when I "press edit -> change something -> submit the changes -> turn to view mode."

No effect: "F5 / reload"

I can 'cure' it with

  • killing the Browser tab, or
  • navigate back to list & click on the issue anew.

@sdwolfz
Copy link
Collaborator

sdwolfz commented Jan 10, 2017

@SkunkerAG I am unable to reproduce this on IE11, but I have a newer version: 11.0.14393.0 and also running on Windows 10. Not sure if this this bug is related to the browser or some other JavaScript library from another plugin. Can you please try to reproduce this bug on your system with a fresh Redmine instance and only the redmine_tags plugin?.

Also I am planning to switch the tag-it library with a newer one, hopefully this may resolve more bugs (even the one related to Cyrillic characters)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants