Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracelog truncation can make output longer. #2095

Open
ecordell opened this issue Jul 23, 2024 · 0 comments
Open

Tracelog truncation can make output longer. #2095

ecordell opened this issue Jul 23, 2024 · 0 comments

Comments

@ecordell
Copy link
Contributor

This is a pretty small nitpick, but I noticed:

a = fmt.Sprintf("%x (truncated %d bytes)", v[:64], len(v)-64)

The message indicating truncation can take up more space than the number of bytes being removed - i.e. if you commonly have values of 65 bytes, it will truncate 1 byte but print out an extra (truncated 1 bytes), which is 20 more bytes. Maybe changing this can be rolled into a solution for #998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant