Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOAP API client should have unit tests #72

Open
vlouvet opened this issue Dec 27, 2023 · 1 comment
Open

SOAP API client should have unit tests #72

vlouvet opened this issue Dec 27, 2023 · 1 comment

Comments

@vlouvet
Copy link
Contributor

vlouvet commented Dec 27, 2023

The tests/test_soap_api.py file currently only has basic tests for initializing the client, but does not test any functionality beyond that.

It would be best if each function in soap_api/client.py had documentation added, and a unit test added.

With these tests added, we can start extending and testing functionality such as pagination and advanced SuiteQL queries (mentioned in a different issue).
@iloveitaly
Copy link
Collaborator

Agreed! Would love a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iloveitaly @vlouvet