Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and update integration test with the versions of Kafka Jaeger supports #3068

Open
Ashmita152 opened this issue Jun 8, 2021 · 7 comments · May be fixed by #6400
Open

Document and update integration test with the versions of Kafka Jaeger supports #3068

Ashmita152 opened this issue Jun 8, 2021 · 7 comments · May be fixed by #6400
Labels
area/storage documentation enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement storage/kafka v2

Comments

@Ashmita152
Copy link
Contributor

Ashmita152 commented Jun 8, 2021

Requirement - what kind of business use case are you trying to solve?

Update jaeger-v2 kafka integration tests to test with the two most recent versions of Kafka

Problem - what in Jaeger blocks you from solving the requirement?

Right now we don't mention anywhere in the doc the version of kafka we support. This has lead to multiple open issues: #3059 #2950 #2068

Although Sarama says "Sarama is a Go library for Apache Kafka 0.8, and up." but their functional tests only test for kafka v2.7.1 and v2.8.0.

The dependabot or other PR bump up the version of Sarama which may break integration with older version of kafka.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Update kafka integration test for each kafka versions we support just like how we do for ES

Any open questions to address

This will increase the integration test time but I think we should do it to prevent unknown breaking changes.

@jpkrohling
Copy link
Contributor

We have a couple of action items here. An initial suggestion could be:

  1. Establish a version policy for Kafka support. For instance, in the Kubernetes world, it's common to support N-2 minor versions. Our promise on the operator is then that people can use any one of those 3 versions and expect Jaeger to work.
  2. Once the policy is established, document it.
  3. We can then use the latest version in the CI tests, with the other versions as part of a nightly build. This way, we keep the CI waiting times short, while still catching issues in a timely fashion. This can be a job that can be triggered on-demand as well so that we run it before releasing as well.

About the nightly jobs: I think we could even consider moving some of the tests we have from the CI to the nightly build as well.

Rinse and repeat for other storage mechanisms :-)

@pavolloffay
Copy link
Member

Great topic :)

Note that in the future Jaeger will use Kafka implementation from OTEL collector. It's a newer implementation that does not use deprecated sarama-cluster implementation. Therefore the OTELcollector might be a better place for the itest.

@dgoscn
Copy link

dgoscn commented Jun 8, 2021

Special thanks @Ashmita152.

Excellent topic

@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners v2 labels Aug 4, 2024
@Mayank77maruti
Copy link

Hey @yurishkuro , is this issue open to work on, I would love to complete it.

@yurishkuro
Copy link
Member

hi @Mayank77maruti - sure, give it a try. We have examples of testing different backend versions with Elasticsearch.

@zzzk1
Copy link

zzzk1 commented Dec 24, 2024

Hi @Mayank77maruti, are you still working on this? If you don't have much time, I would like to give it a try.

@Mayank77maruti
Copy link

Hey @zzzk1 i am not working on it.
@zzzk1 you can take up the issue.
Thank you.

@zzzk1 zzzk1 linked a pull request Dec 24, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage documentation enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement storage/kafka v2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants