[e2e] Use APIv3 gRPC endpoint for remote queries #6422
Labels
Comments
yurishkuro
added a commit
that referenced
this issue
Dec 27, 2024
## Which problem is this PR solving? - Part of #6422 - We cannot use api_v3 proto types outside of query service (namely from e2e v2 integration tests) because they are in the `internal` package ## Description of the changes - Move api_v3 to `internal/proto/api_v3` to be accessible from all of the code base ## How was this change tested? - CI Signed-off-by: Yuri Shkuro <[email protected]>
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this issue
Jan 5, 2025
## Which problem is this PR solving? - Part of jaegertracing#6422 - We cannot use api_v3 proto types outside of query service (namely from e2e v2 integration tests) because they are in the `internal` package ## Description of the changes - Move api_v3 to `internal/proto/api_v3` to be accessible from all of the code base ## How was this change tested? - CI Signed-off-by: Yuri Shkuro <[email protected]>
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this issue
Jan 5, 2025
## Which problem is this PR solving? - Resolves jaegertracing#6422 ## Description of the changes - Replace span_reader (api_v2 gRPC client) with trace_reader (api_v3 gRPC client) - Set ingester logs to `info` because `kafkareceiver` logs the binary content of the messages via `debug` - Move logic related to child process into `binary.go` - Preserve original config file name for readability when modifying it to add storage cleaner extension - Add timeout to `writeTrace()` - Bumped into a subtle issue that if Cmd.Env is not nil then the sub-process does not inherit any other env from the parent, which was causing issues with Kafka tests where we pass topic & encoding via env, but for V2 Reader I had to add another env to disable self-tracing. Changed this to always pass EnvOverrides directly via Cmd.Env instead of setting them on the parent process. ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Mahad Zaryab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently e2e integration tests perform reads from storage by querying APIv2 gRPC endpoint in the
jaegerqueryextension. Since the tests were migrated to use Storage V2 API (in #6388) we can go directly to APIv3 endpoint and avoid model<>ptraces translations. Longer term we want the same API to be used as Remote Storage API v2.The text was updated successfully, but these errors were encountered: