Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on internal tag/attribute naming as @jaeger@something #6522

Closed
yurishkuro opened this issue Jan 11, 2025 · 2 comments · Fixed by #6524
Closed

Standardize on internal tag/attribute naming as @jaeger@something #6522

yurishkuro opened this issue Jan 11, 2025 · 2 comments · Fixed by #6524
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

Currently we use inconsistent naming for internal attributes

I propose we use a shorter but more distinct naming scheme that does not match the normal dot-separated format of OTEL attributes. The above three keys would become

  • @jaeger@warnings
  • @jaeger@format ("span" is implied since it's on the span)
  • @jaeger@hash ("span" is implied since it's on the span)
@yurishkuro yurishkuro added good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement labels Jan 11, 2025
@yurishkuro yurishkuro mentioned this issue Jan 11, 2025
Draft
4 tasks
@ADI-ROXX ADI-ROXX mentioned this issue Jan 11, 2025
Merged
3 tasks
@ADI-ROXX
Copy link
Contributor

ADI-ROXX commented Jan 11, 2025 •
edited
Loading

jaeger.internal.warnings in internal/jptrace/warning.go
internal.span.format in cmd/collector/app/span_processor.go

@yurishkuro Apart from the above naming conventions and span.hash, which will be pushed later on, is there any other naming convention that needs to be changed to "@jaeger@something" format?

@yurishkuro
Copy link
Member Author

I don't recall if we have any other internal tags.

ekefan pushed a commit to ekefan/jaeger that referenced this issue Jan 14, 2025
@ADI-ROXX @yurishkuro @ekefan
Add standard tags for internal warnings and span format (jaegertracin…
aeb1b11 
…g#6524)

## Which problem is this PR solving?
- Resolves jaegertracing#6522 

## Description of the changes
- Replaced the names of non-standard tags with standard tags

## How was this change tested?
- make test returned pass for all the test cases

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make test`

---------

Signed-off-by: cs-308-2023 <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add standard tags for internal warnings and span format ADI-ROXX/jaeger
2 participants
@yurishkuro @ADI-ROXX