Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key timeoutSeconds key in chart admission-registration.yaml. #201

Open
paritosh-upadhyay1 opened this issue Sep 4, 2024 · 2 comments

Comments

@paritosh-upadhyay1
Copy link

If any user wants to increase timeoutSeconds in ValidatingWebhookConfiguration and MutatingWebhookConfiguration for the tugger he can’t pass this value in values.yaml file. Currently, your chart is setting default timeoutSeconds i.e. 10 seconds.

@jainishshah17
Copy link
Owner

@paritosh-upadhyay1 Thank you for reporting this. I will try to make it configurable.

@kd7lxl
Copy link
Collaborator

kd7lxl commented Sep 9, 2024

It's true that this isn't configurable in this chart, but I've used ValidatingWebhookConfigurations and MutatingWebhookConfigurations pretty heavily and never needed to change this timeout. I wonder if there's an XY problem here. Why do you need to override this timeout? Tugger should be able to evaluate the rewrite policy very fast. The only case that might have some latency is condition: Exists because it requires a network request, but even that should easily be completed in under 10 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants