Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daos should have a consistent contract, false on error? Move all logic to controllers #103

Open
jakethedev opened this issue Jan 27, 2022 · 0 comments
Open

Daos should have a consistent contract, false on error? Move all logic to controllers #103

jakethedev opened this issue Jan 27, 2022 · 0 comments
Labels
blocker Preventing work on a feature documentation Improvements or additions to documentation enhancement Slight upgrade but less than a feature
Milestone
Low Priority

Comments

@jakethedev
Copy link
Owner

There isn't a consistent approach, and sometimes we're returning string results from the dao to the user via controller. This is nasty, and not in the hot way, so it needs to be fixed, documented, and followed.

Additional thoughts: look up a good SQL / Mongo driver api, see if we can think ahead and have controller logic already in a healthy place for that transition

Blocks #21 (migrating to a database)
@jakethedev jakethedev added documentation Improvements or additions to documentation enhancement Slight upgrade but less than a feature blocker Preventing work on a feature labels Jan 27, 2022
@jakethedev jakethedev added this to the Low Priority milestone Jan 27, 2022
@jakethedev jakethedev mentioned this issue Jan 27, 2022
Open
@jakethedev jakethedev changed the title BattleDao etc need to return data or true for success, false for anything else Daos should have a consistent contract, false on error? Move all logic to controllers Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker Preventing work on a feature documentation Improvements or additions to documentation enhancement Slight upgrade but less than a feature
Projects
None yet
Milestone
Low Priority
Development

No branches or pull requests
1 participant
@jakethedev