Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Polar Widgets #620

Open
crisdut opened this issue Nov 8, 2022 · 4 comments
Open

Feature Request: Polar Widgets #620

crisdut opened this issue Nov 8, 2022 · 4 comments
Labels
enhancement New feature or request needs planning Talk to maintainers before working on this up for grabs Anyone can work on this

Comments

@crisdut
Copy link

crisdut commented Nov 8, 2022

Polar is a great project, and I like to use it to explain how LN works and show the possibilities of the network. However, sometimes I miss some features to help me, like "step-by-step guides" or "tutorials".

But extending Polar with these features will increase complexity and is out of scope.

Because of this, I start thinking about changing Polar to support Widgets.

How Works

I think exists two ways to make this works:

  1. Create a type of "react event bus hook" to nodes and actions commands to allow the widgets to intercept and process events.
  2. Change Sidebar to supports inject new "Actions".

Example:

Imagine a tutorial Widget called "My First Invoice", like a IntroJS.

To build this, I need to check if "Create Invoice" and "Pay Invoice" is called to my widget works.

Event Bus Example: here

Does make sense to you?

@crisdut crisdut added the enhancement New feature or request label Nov 8, 2022
@jamaljsr
Copy link
Owner

jamaljsr commented Nov 9, 2022

I think I understand what you are trying to accomplish. You'd like some extensibility points added to Polar which would allow others to create widget-like plugins that add additional functionality, such as step-by-step tutorials. Are you imagining the widgets living in the same codebase as Polar, or external plugins that can be loaded in at runtime?

@crisdut
Copy link
Author

crisdut commented Nov 9, 2022

I think I understand what you are trying to accomplish. You'd like some extensibility points added to Polar which would allow others to create widget-like plugins that add additional functionality, such as step-by-step tutorials. Are you imagining the widgets living in the same codebase as Polar, or external plugins that can be loaded in at runtime?

Hi @jamaljsr,

Yes, exactly.

Well, I think the best solution is external repos. The users install widgets by command line or with an interface with a list of widgets.

@jamaljsr
Copy link
Owner

This is an interesting idea. It's not something I can prioritize working on at the moment, but I would be fine reviewing a PR if someone else wants to work on implementing it.

@crisdut
Copy link
Author

crisdut commented Nov 15, 2022

This is an interesting idea. It's not something I can prioritize working on at the moment, but I would be fine reviewing a PR if someone else wants to work on implementing it.

Ok, don't worry.

I opened the PR to share some ideas.

Next week, I will start the implementation.

Thanks for feedback!

@jamaljsr jamaljsr added up for grabs Anyone can work on this needs planning Talk to maintainers before working on this labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs planning Talk to maintainers before working on this up for grabs Anyone can work on this
Projects
None yet
Development

No branches or pull requests

2 participants