Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On browser-selection, show which browsers don't support auto-proxy-setup #333

Open
mitchhentges opened this issue Jun 5, 2017 · 3 comments

Comments

@mitchhentges
Copy link
Member

Currently in master, we warn users that "some browsers" can't be automatically set up to proxy. We should instead just add a ui element to each browser that can't be automatically set up, so users know exactly which browsers require additional configuration.

@nerdbeere
Copy link
Member

Maybe we should just show the browsers we can automatically set up? Maybe with a note that other browsers lack this feature.

@mitchhentges
Copy link
Member Author

It makes sense that we should definitely prioritize browsers that we can automatically configure, but I'm worried that if we don't show browsers that we cannot auto-setup, then users will think that James can't work at all with those other browsers.

Perhaps we can have the main list of browsers as we have it today, but that list only has browsers that we can automatically configure. Then, below, as a sub-note, we can show other browsers detected, but have a note saying that the user will manually have to set up the browsers to point to localhost:$port

@tomitm
Copy link
Contributor

tomitm commented Dec 30, 2017

Guessing we need to whitelist browsers that support auto configuration.

We can move the unsupported browsers into a separate section below with a wiki link to an explanation. I was thinking of doing something similar for #43 to show a message when we detect HTTPS proxying isn't setup and clearly call it out on the homepage, rather than only vaguely in the footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants