Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows signing #354

Open
tomitm opened this issue Dec 30, 2017 · 0 comments
Open

Windows signing #354

tomitm opened this issue Dec 30, 2017 · 0 comments
Labels
os/Windows

Comments

@tomitm
Copy link
Contributor

tomitm commented Dec 30, 2017 •
edited
Loading

SmartScreen is semi-blocking the new NSIS installer.

image

Once you hit More info, it allows you to install just fine, but this might confuse some people.

https://www.electron.build/code-signing#windows

  • Looks like we need a code-signing cert which will work with CI but will still displays a warning until we have enough users.
  • Wonder if @nerdbeere's macOS developer cert will work on Windows - need to configure it on AppVeyor.
  • Not sure (until beta 2) if this will block updates. Updates confirmed to still work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
os/Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomitm