Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check CLI text translation state and consider enabling translations when headless #3195

Open
pljones opened this issue Oct 27, 2023 · 0 comments
Labels
feature request Feature request

Comments

@pljones
Copy link
Collaborator

pljones commented Oct 27, 2023

What is the current behaviour and why should it be changed?

The client and server code behave differently on start up when headless, in regards to loading translations.

Ideally both would load translations once the application instance had been created and all text displayed - either in the GUI or to the console - would be translatable.

Describe possible approaches

  • Review existing code to identify any text that should be translated that is not.
  • Review existing code to identify any text that should not be translated that is.
  • Raise a PR to resolve the above.
  • Once that's done, review the start up code in src/main.cpp to ensure translations are loaded as soon as the run time language has been established. Currently, this must be after command line and settings processing as both can affect the language selection.

Has this feature been discussed and generally agreed?

Mentioned, possibly several times, previously. Most recently in #3139.

@pljones pljones added the feature request Feature request label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
Status: Triage
Development

No branches or pull requests

1 participant