Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process error and warning for 3.11.0rc1 #3373

Open
pljones opened this issue Sep 14, 2024 · 5 comments · Fixed by #3374
Open

Build process error and warning for 3.11.0rc1 #3373

pljones opened this issue Sep 14, 2024 · 5 comments · Fixed by #3374
Labels
bug Something isn't working

Comments

@pljones
Copy link
Collaborator

pljones commented Sep 14, 2024

Describe the bug

When editing the 3.11.0rc1 release, I noticed the following error:
image

Probably something in the deployment scripts.

There's also a warning relating to macOs in the output:
image
but may not be related.

To Reproduce

Cut a release candidate.

Expected behavior

No errors

Version of Jamulus

3.11.0rc1 release build.

@pljones pljones added the bug Something isn't working label Sep 14, 2024
@pljones pljones added this to the Release 3.11.0 milestone Sep 14, 2024
@ann0see
Copy link
Member

ann0see commented Sep 14, 2024

I don't think they are related. I believe there's something wrong in two places.

  1. Deployment upload
  2. macOS caching

@ann0see
Copy link
Member

ann0see commented Sep 14, 2024

For 1, the cleanest way would be to call gh release upload in the respective scripts instead of the hacky cross platform method we use currently:

gh release upload "${{ needs.create_release.outputs.tag_name }}" "deploy/${{ steps.get-artifacts.outputs.artifact_1 }}" "deploy/${{ steps.get-artifacts.outputs.artifact_2 }}" --clobber
||
gh release upload "${{ needs.create_release.outputs.tag_name }}" "deploy/${{ steps.get-artifacts.outputs.artifact_1 }}" --clobber

The issue is Windows:
cli/cli#5099

Otherwise, we could just upload every file from the deploy directory with a wildcard.

For 2, further investigation is needed.

@ann0see
Copy link
Member

ann0see commented Sep 14, 2024

I think for now we'll just split the release upload into two artifacts again.

https://github.com/ann0see/jamulus/releases/tag/r0_3_10_0

@ann0see
Copy link
Member

ann0see commented Sep 14, 2024

Concerning 2, it seems to be comparable to actions/setup-node#362

Maybe we need to use a non standard location to put Qt to, or just delete the cache.

@pljones
Copy link
Collaborator Author

pljones commented Sep 16, 2024

OK, as it doesn't appear to have a discernable negative effect, I'm bumping the problem to after the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Triage
Development

Successfully merging a pull request may close this issue.

2 participants