Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report multiple errors #11

Open
panglesd opened this issue Mar 11, 2023 · 0 comments
Open

Report multiple errors #11

panglesd opened this issue Mar 11, 2023 · 0 comments
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@panglesd
Copy link

It would be nice if, when relevant, ppx_custom_yojson would embed the error instead of raising.

For instance, in:

let invalid1 =
  Format.printf !"The time is %{invalid#invalid} and the timezone is %{invalid#too}." time timezone

Currently, only the first error (string "invalid#invalid" should be of the form [...]) is reported, Merlin can't find any information about the arity of the generated function.

I would like to use this issue for an Outreachy project (see ocaml-ppx/ppxlib#389). If you are willing to accept contributions, I would help in the reviewing process!

@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

No branches or pull requests

2 participants