Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deserialize is never called.. #45

Open
JohnMcLear opened this issue Jun 22, 2015 · 0 comments
Open

deserialize is never called.. #45

JohnMcLear opened this issue Jun 22, 2015 · 0 comments

Comments

@JohnMcLear
Copy link

Visiting /p/foo
Returns

[2015-06-22 22:15:02.736] [INFO] console - Trying to access a pad /p/foo
[2015-06-22 22:15:02.736] [WARN] console - isAuthenticated false
[2015-06-22 22:15:02.736] [WARN] console - passing back to auth as not authenticated
[2015-06-22 22:15:04.122] [INFO] console - successful auth through Github
[2015-06-22 22:15:04.123] [INFO] console - serialized user { provider: 'github', ...  omitted ...  }
[2015-06-22 22:15:04.128] [INFO] console - Redirecting back to home after succesful auth

Then trying to visit another pad without stopping / starting Etherpad or closing browser returns..

[2015-06-22 22:16:10.500] [INFO] console - Trying to access a pad /p/oWtSRH2g01
[2015-06-22 22:16:10.500] [WARN] console - isAuthenticated false
[2015-06-22 22:16:10.500] [WARN] console - passing back to auth as not authenticated
[2015-06-22 22:16:11.827] [INFO] console - successful auth through Github
[2015-06-22 22:16:11.827] [INFO] console - serialized user { provider: 'github',

So the isAuthenticated persistence isn't being kept

https://github.com/JohnMcLear/ep_oauth/blob/master/auth.js#L28 -- Am I okay to not use app.use(express.methodOverride()); and the other express calls in the example app?

These methods don't seem to be responsible for persistence.. I'm ultimately going to write to/read from the database layer but for now I want a clean sample/example to do proof of concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant