Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t override browser keyboard shortcuts on OS X #3

Open
roryokane opened this issue Apr 13, 2014 · 1 comment
Open

Don’t override browser keyboard shortcuts on OS X #3

roryokane opened this issue Apr 13, 2014 · 1 comment

Comments

@roryokane
Copy link

In Firefox 28 on OS X, the demo page swallows most keyboard shortcuts I try to use to control the browser. Any shortcut using a key that the demo uses is overridden, and interpreted as a command to the demo instead of to the browser, as if I had not held down Command. The most annoying overrides are ⌘L to focus the location bar and ⇧⌘{ and ⇧⌘} to switch tabs.

Where the code sets up keyboard shortcuts (probably keys.js or attachListeners in view.js), the state of the Command key should be checked when a keypress is detected. If Command is being held and the shortcut doesn’t require it, then the handler should not trap the keypress event.

@jaredly
Copy link
Owner

jaredly commented Apr 18, 2014

Ah yes, sorry about that. I'm devving on a linux box so "alt" is what the keyboard mapping states. I'll have to look into sniffing for Mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants