Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix search results page should mention if no matches were found #73

Open
akoeplinger opened this issue Nov 2, 2020 · 1 comment
Open

Comments

@akoeplinger
Copy link
Contributor

Right now it displays a confusing view where it shows the empty results table including pagination buttons and "Results for 0-50 of 103 builds".

This makes it look like runfo broke but I think what happens is that there were 103 builds but none contained the search string?

Example query: https://runfo.azurewebsites.net/search/helix-logs/?bq=definition%3Aruntime+kind%3Arolling+result%3A%21succeeded+started%3A%7E2&lq=logkind%3Aconsole+text%3A%22foobar%22

image

@akoeplinger akoeplinger changed the title Search results page should mention if no matches were found Helix search results page should mention if no matches were found Nov 2, 2020
@jaredpar
Copy link
Owner

jaredpar commented Nov 2, 2020

Will clean this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants