-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fa icons are not displayed #108
Comments
@Skyflash now Jalpc is using font awesome v4.7, the icon fa-nintendo-switch is showing at font awesome v5, it's better to upgrade the version. :) |
Ummh... let me understand. Can i upgrade myself to v5? I've tried modify the version in the package.json without luck. |
@Skyflash Do you reinstall packages( |
I've never update package.json :) |
@Skyflash THis is Javascript stuff,
After your update is done, you should compress CSS/JS files then push code to GitHub. I will update this code in https://github.com/jarrekk/Jalpc, maybe you can get a new code from here. :) |
Ok. Now, under dependencies, i have: I think i'll have to google how i can upgrade to 5, isn't it? :D Or i can wait your modifications and copy them into my code. I have added the jekyll-seo-tag plugin, modified the html code for the descriptions, excerpts and i modified the footer includes (now the footer is only one and the if logic is into that) |
@Skyflash glad to hear this, some investigation just now, font-awesome 5.* is not compatible for font-awesome 4.* and font-awesome 5.* has a pro version which needs to pay for it, I need to have more work on this, but you can try on your code. |
I'm playing with your theme and i've found some icons (example: fa-nintendo-switch) are not displayed in the skill_icon1 and 2 sections
The text was updated successfully, but these errors were encountered: