Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: SDBL alignment relies on uniform distribution instead of logistic #27

Open
vkhodygo opened this issue Aug 4, 2022 · 1 comment

Comments

@vkhodygo
Copy link
Collaborator

vkhodygo commented Aug 4, 2022

See original research.

SBDLAlignment class used to use the same RNG (see also #26) as SBDAlignment for generation of random numbers before and even now in v5.0.0. This is incorrect, SBDLAlignment must rely on the conventional logistic distribution.

@vkhodygo
Copy link
Collaborator Author

vkhodygo commented Aug 4, 2022

Correction: the original source is inconsistent as well. The text says:

r_i that is drawn from a logistic distribution

Whereas the Algorithm 6 states:

r_i ← a random number from uniform distribution (0,1)

This looks like some sort of a copy-paste error to me. The logistic distribution is bounded meaning 1 / r - 1 is bounded as well resulting in finite values of log(1 / r - 1) whereas this is not the case for the uniform distribution (0, 1). However, the uniform distribution is strictly positive as opposed to the logistic one that is defined on the whole R.

Note, that the original paper makes a clear distinction between open and closed intervals such as (0, 1) and [0, 1]. That means using the default rng generating values in the range [0, 1) is incorrect even in the case of SBDAlignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant