Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling modify() #9

Open
stevenao opened this issue Jan 11, 2017 · 1 comment
Open

calling modify() #9

stevenao opened this issue Jan 11, 2017 · 1 comment
Assignees
Labels

Comments

@stevenao
Copy link

When i try to call myitem.object.first.modify(), and in the serialized json, i will get something like "Article:http://www.w3.org/ns/activitystreams#Object". That doesn't seem right to me.

I see it is coming from the _object.js constructor: https://github.com/jasnell/activitystrea.ms/blob/master/src/models/_object.js#L123. Do we need to append the as.Object type when there is types defined already?

stevenao added a commit to stevenao/activitystrea.ms that referenced this issue Jan 11, 2017
@jasnell
Copy link
Owner

jasnell commented Mar 6, 2017

I know it's been a while, but, can you provide a test case I can use to reproduce

@evanp evanp added the bug label Apr 20, 2018
@evanp evanp self-assigned this Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants