Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutate auto model would not cause rerender #178

Open
jason89521 opened this issue Jul 20, 2023 · 0 comments
Open

mutate auto model would not cause rerender #178

jason89521 opened this issue Jul 20, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jason89521
Copy link
Owner

Currently the auto accessor only notifies the listener inside it instead of notifying the whole model. If developers mutate the model, it would not cause a rerender.

We have two way to fix it:

  1. notify the corresponding accessor when developers mutate the model
  2. remove the self listeners, the accessor directly notify the model's listeners

I prefer the first approach.

@jason89521 jason89521 added bug Something isn't working good first issue Good for newcomers labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant